-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare ci tools for extensions without DuckDB submodule #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
maybe wait a sec with this one, running into more issues with the rust template 🙄 |
samansmink
changed the title
Improve testing mechanism
Prepare ci tools for extensions without DuckDB submodule
Nov 6, 2024
See CI run for the Rust template running in this here https://github.com/samansmink/extension-template-rs/actions/runs/11706753411 |
carlopi
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, my experimental rust-based extension template (https://github.com/samansmink/extension-template-rs) should be one step closer to reality.
This requires some tweaks to the workflows because things like running tests and platform detection are different from the C++ api based extensions that do have a duckdb submodule in their repository.
Changes:
configure_ci
step which is called once inside docker, once outsidetest_*
targets no longer automatically build too, this avoids double building that would happencustom-toolchain-script.sh
was removed again in favor of more flexiblemake configure_ci