Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare ci tools for extensions without DuckDB submodule #98

Merged
merged 13 commits into from
Nov 7, 2024

Conversation

samansmink
Copy link
Collaborator

@samansmink samansmink commented Oct 15, 2024

After this PR, my experimental rust-based extension template (https://github.com/samansmink/extension-template-rs) should be one step closer to reality.

This requires some tweaks to the workflows because things like running tests and platform detection are different from the C++ api based extensions that do have a duckdb submodule in their repository.

Changes:

  • you can now disable running the tests by setting the SKIP_TESTS variable
  • tests on linux are now run twice: once inside docker, once outside
  • there's a new configure_ci step which is called once inside docker, once outside
  • extensions can detect which one is being called and set SKIP_TESTS for either to work around any issues
  • test_* targets no longer automatically build too, this avoids double building that would happen
  • custom-toolchain-script.sh was removed again in favor of more flexible make configure_ci

@samansmink samansmink requested a review from carlopi October 15, 2024 09:52
Copy link
Collaborator

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@samansmink
Copy link
Collaborator Author

maybe wait a sec with this one, running into more issues with the rust template 🙄

@samansmink samansmink changed the title Improve testing mechanism Prepare ci tools for extensions without DuckDB submodule Nov 6, 2024
@samansmink
Copy link
Collaborator Author

See CI run for the Rust template running in this here https://github.com/samansmink/extension-template-rs/actions/runs/11706753411

@samansmink samansmink requested a review from carlopi November 7, 2024 08:46
@samansmink samansmink merged commit bb3809d into duckdb:main Nov 7, 2024
19 checks passed
@samansmink samansmink deleted the minor-ci-tweaks branch November 7, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants